z: Add TotalSize method on bloom filter #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
all-seeing-code,
karlmcguire,
manishrjain and
martinmr
as code owners
jarifibrahim
changed the title
martinmr
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anurags92, @jarifibrahim, @karlmcguire, and @manishrjain)
z/bbloom.go, line 136 at r1 (raw file):
len(bl.bitset)*8 + 5*8
maybe set this as constants. not clear what 5*8 represents.
jarifibrahim
pushed a commit
to dgraph-io/badger
that referenced
this pull request
Oct 3, 2020
This PR depends upon dgraph-io/ristretto#197 `badger info` now shows index size and bloom filter size
manishrjain
pushed a commit
to outcaste-io/outserv
that referenced
this pull request
Jul 6, 2022
This PR depends upon dgraph-io/ristretto#197 `badger info` now shows index size and bloom filter size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
TotalSizefunction which returns the total size of the bloom filter.This change is