Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make item public. Add a new onReject call for rejected items. #180

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Make item public. Add a new onReject call for rejected items. #180

merged 2 commits into from
Aug 17, 2020

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Aug 17, 2020 •
edited
Loading

  • Making Item public makes the onEvict and onReject function calls more readable.
  • Adding onReject allows us to tightly track every Set that happens, so we can avoid memory leaks in manually allocated memory.

This change is Reviewable

jarifibrahim
jarifibrahim approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @anurags92, @karlmcguire, and @martinmr)

jarifibrahim
jarifibrahim reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anurags92 will add tests later.

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @anurags92, @karlmcguire, and @martinmr)

all-seeing-code
all-seeing-code reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@all-seeing-code all-seeing-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @anurags92, @karlmcguire, and @martinmr)

all-seeing-code
all-seeing-code approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@all-seeing-code all-seeing-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @anurags92, @karlmcguire, and @martinmr)

@manishrjain manishrjain merged commit 18e2797 into master Aug 17, 2020
@manishrjain manishrjain deleted the mrjn/onReject branch August 17, 2020 12:49
@jarifibrahim
Copy link
Contributor

The TestDropUpdates works fine locally. It could be a Travis issue (the test has a time.Sleep) or a go 1.12 .
@anurags92 @jarifibrahim to investigate it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@karlmcguire karlmcguire Awaiting requested review from karlmcguire

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manishrjain @jarifibrahim @all-seeing-code