Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify type system in test cases #116

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Simplify type system in test cases #116

merged 1 commit into from
Oct 2, 2019

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Oct 2, 2019 •
edited by manishrjain
Loading

This change is Reviewable

pullrequest[bot]
pullrequest bot reviewed Oct 2, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@mangalaman93 you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Oct 2, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

@mangalaman93 mangalaman93 requested a review from martinmr October 2, 2019 19:00
martinmr
martinmr approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mangalaman93 mangalaman93 merged commit fdded03 into master Oct 2, 2019
@mangalaman93 mangalaman93 deleted the aman/type_simple branch October 2, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@martinmr martinmr martinmr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangalaman93 @martinmr