Fix how query responses are sent in upsert HTTP responses. #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the results of the upsert query are attached to the final response at the same level as other field (e.g "message", "code") which introduces the restriction that the names of these fields cannot be used to name queries. This PR gets rid of this restriction by attaching the response to the queries in the "queries" field. This eliminates the need to check for certain keywords in the query.
|
@mangalaman93 Is there any changes that have to be done for gRPC responses? |
|
gRPC response is fine. Please get it approved by @manishrjain before we merge. |
manishrjain
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mangalaman93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the results of the upsert query are attached to the final
response at the same level as other field (e.g "message", "code") which
introduces the restriction that the names of these fields cannot be used
to name queries.
This PR gets rid of this restriction by attaching the response to the
queries in the "queries" field. This eliminates the need to check for
certain keywords in the query.
Fixes #4361
This change is