Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that reproduces the issue #3853

Closed
wants to merge 1 commit into from
Closed

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Aug 23, 2019

Fixes #3840


This change is Reviewable

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@mangalaman93 you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job getting a test to reproduce this issue. I'm wondering if it would be useful to add an inline TODO or something as well if this is behavior that should be fixed or is currently failing?


Reviewed with ❤️ by PullRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1.1.0-rc1: count selector at root ignores given value
2 participants