Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that uid is not used as function attribute #3112

Merged
merged 25 commits into from
Mar 15, 2019
Merged

Check that uid is not used as function attribute #3112

merged 25 commits into from
Mar 15, 2019

Commits on Mar 9, 2019

  1. gql/parser.go: disallow uid as attribute in functions 

    This change adds a check in the Gql parser to prevent functions from
using `uid` as an attribute. `uid` is a protected attribute that
should not be used directly but instead via function `uid()`.
    srfrog committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    86c428b View commit details
    Browse the repository at this point in the history

  2. gql/parser_test.go: add more test cases for uid in functions

    srfrog committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    ffafaac View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/iss… 

    …ue-3110_srcuids_assertion_fail
    srfrog committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    c11082d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. gql/parser.go: remove uid attribute tests in parser

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    d34ee08 View commit details
    Browse the repository at this point in the history

  2. query/query.go: add check for invalid uid attributes when newGraph

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    21a9208 View commit details
    Browse the repository at this point in the history

  3. gql/parser_test.go: remove obsolete parser tests

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    a604ea8 View commit details
    Browse the repository at this point in the history

  4. query/query.go: match error with existing tests

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    62200a8 View commit details
    Browse the repository at this point in the history

  5. systest/queries_test.go: remove obsolete test expecting parser error

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    2110658 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/iss… 

    …ue-3110_srcuids_assertion_fail
    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    7e1cd99 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/iss… 

    …ue-3110_srcuids_assertion_fail
    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    40cf789 View commit details
    Browse the repository at this point in the history

  8. query/query1_test.go: add query tests for uid attr

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    34ef382 View commit details
    Browse the repository at this point in the history

  9. query/query1_test.go: readd missing test case

    srfrog committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    048a8b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/iss… 

    …ue-3110_srcuids_assertion_fail
    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    924149b View commit details
    Browse the repository at this point in the history

  2. query/query0_test.go: add test for empty values comparison functions,… 

    … filters.
    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    9bb03d3 View commit details
    Browse the repository at this point in the history

  3. query/query.go: add check for uid attr in filters, minor syntax and t… 

    …ypo cleanups
    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    abf6c6e View commit details
    Browse the repository at this point in the history

  4. query/query1_test.go: add tests for functions with uid attribute

    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    6823c41 View commit details
    Browse the repository at this point in the history

  5. query/query3_test.go: add test for regexp() with empty value

    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    2fca6da View commit details
    Browse the repository at this point in the history

  6. worker/task.go: nicer error for syntax error for conversion of NaN

    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    241a8cc View commit details
    Browse the repository at this point in the history

  7. query/query0_test.go: add tests for functions with empty string value

    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    3d80238 View commit details
    Browse the repository at this point in the history

  8. query/query.go: prevent some children functions from using uid attribute

    srfrog committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    3df98de View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into srfrog/issue-3110_srcuids_assertion_fail

    @srfrog
    srfrog authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    12cb393 View commit details
    Browse the repository at this point in the history

  2. query/query1_test.go: fix typo in test

    srfrog committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    4fa8f3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'srfrog/issue-3110_srcuids_assertion_fail' of github.com… 

    …:/dgraph-io/dgraph into srfrog/issue-3110_srcuids_assertion_fail
    srfrog committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    e99ba79 View commit details
    Browse the repository at this point in the history

  4. worker/task.go: add value to error message, update the test

    srfrog committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6eaa243 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into srfrog/issue-3110_srcuids_assertion_fail

    @srfrog
    srfrog authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    9db736d View commit details
    Browse the repository at this point in the history