Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for multi-part lists #3105

Merged
merged 82 commits into from
Apr 19, 2019
Merged

Initial commit for multi-part lists #3105

merged 82 commits into from
Apr 19, 2019

Commits on Mar 6, 2019

  1. Initial commit for multi-part lists

    @martinmr
    martinmr committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    e8b96e6 View commit details
    Browse the repository at this point in the history

  2. Decide if list needs to be split based on approxLen.

    @martinmr
    martinmr committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    8aff4a7 View commit details
    Browse the repository at this point in the history

  3. Use size instead of length to do split decisions.

    @martinmr
    martinmr committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    dd630c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Several changes. 

    - Load whole list at once.
- Eliminate linked list.
- Store all plists inside the List object.
    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    f6125ba View commit details
    Browse the repository at this point in the history

  2. Increase test size and remove print statements

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b572a39 View commit details
    Browse the repository at this point in the history

  3. Combine partial and complete iterations into the same function.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e9d3f05 View commit details
    Browse the repository at this point in the history

  4. Remove unused function and optimize rollup.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    9f8d54f View commit details
    Browse the repository at this point in the history

  5. Add extra test.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    4dc9397 View commit details
    Browse the repository at this point in the history

  6. Add extra tests

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    fc4c183 View commit details
    Browse the repository at this point in the history

  7. Remove first_part field from proto.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    75db0f5 View commit details
    Browse the repository at this point in the history

  8. Fix bug in Uids function.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e29a15d View commit details
    Browse the repository at this point in the history

  9. Removed unused field

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    ebd8303 View commit details
    Browse the repository at this point in the history

  10. Simplify rollup logic.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    0250636 View commit details
    Browse the repository at this point in the history

  11. Change order of if-statements.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b0eddc4 View commit details
    Browse the repository at this point in the history

  12. Remove unused field.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    aad3f20 View commit details
    Browse the repository at this point in the history

  13. Load list parts on demand. Also simpler split logic.

    @martinmr
    martinmr committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6029630 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Remove partialIteration field.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    78d35fb View commit details
    Browse the repository at this point in the history

  2. Remove unused proto fields.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    6847378 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary parameter from method.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    29df604 View commit details
    Browse the repository at this point in the history

  4. Variable rename

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    d1d6bce View commit details
    Browse the repository at this point in the history

  5. Clean map of uncommitted lists.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    a9eca0f View commit details
    Browse the repository at this point in the history

  6. Move logic to clean uncommitted list map at the beginning of rollup.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    7670457 View commit details
    Browse the repository at this point in the history

  7. Loop until finding a part with valid entries.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    8cef9e0 View commit details
    Browse the repository at this point in the history

  8. Simplify rollup logic.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    a709f8e View commit details
    Browse the repository at this point in the history

  9. Rename proto field and simplify split logic.

    @martinmr
    martinmr committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    e3de2e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Change tests to read and write posting lists to disk.

    @martinmr
    martinmr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    74b3889 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    4c14401 View commit details
    Browse the repository at this point in the history

  3. remove readListPartFromDisk method.

    @martinmr
    martinmr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    db750d6 View commit details
    Browse the repository at this point in the history

  4. Check error

    @martinmr
    martinmr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    b21038c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Store splits in emptylists and fix logic to decide the list metadata.

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    86c5951 View commit details
    Browse the repository at this point in the history

  2. Check error status of init.

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    d6c5dfb View commit details
    Browse the repository at this point in the history

  3. Fix marshalPostingList

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    f05f3ed View commit details
    Browse the repository at this point in the history

  4. Add flag to control max posting list size.

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    240e898 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    ccb820f View commit details
    Browse the repository at this point in the history

  6. Parse startuid in keys.go and add tests.

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    08e7601 View commit details
    Browse the repository at this point in the history

  7. Update debug tool to understand multi-part lists.

    @martinmr
    martinmr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    f328c18 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Restore comment.

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    3a52162 View commit details
    Browse the repository at this point in the history

  2. Fix posting tests

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    e0d13ac View commit details
    Browse the repository at this point in the history

  3. Add test files.

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    9236018 View commit details
    Browse the repository at this point in the history

  4. Delete unused testing code.

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    becab2d View commit details
    Browse the repository at this point in the history

  5. Remove max_posting_list_size flag

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    294b8d4 View commit details
    Browse the repository at this point in the history

  6. Add extra tests for multi-posting lists.

    @martinmr
    martinmr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    38f7e7e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    af6d2ac View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    92c8a44 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Manish's review. Renamed some funcs, readPartList does not use cache,… 

    … etc.
    @manishrjain
    manishrjain committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    dd9b968 View commit details
    Browse the repository at this point in the history

  2. Fix keys.go tests

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    b114232 View commit details
    Browse the repository at this point in the history

  3. Rename deleteBelow and add sanity check for it.

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    d907e51 View commit details
    Browse the repository at this point in the history

  4. Move iteration logic to Next()

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    2033a41 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    a8bb694 View commit details
    Browse the repository at this point in the history

  6. Add documentation for pickPostings

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    b33444b View commit details
    Browse the repository at this point in the history

  7. Make rollup read-only, remove cache.

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    7dc357e View commit details
    Browse the repository at this point in the history

  8. Remove err from plsAreEmpty

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    92f8724 View commit details
    Browse the repository at this point in the history

  9. Fix marshalling and deletion logic.

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    3dc54ad View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    9cf7130 View commit details
    Browse the repository at this point in the history

  11. Remove start_uid field from proto.

    @martinmr
    martinmr committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    65538a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    b30d1ed View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    58704c4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e197a27 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    ee37481 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Some small nitpick changes.

    @manishrjain
    manishrjain committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    184fc54 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary variables to simplify code reading. Also rename so… 

    …me funcs.
    @manishrjain
    manishrjain committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    dfdf290 View commit details
    Browse the repository at this point in the history

  3. Addresssed review comments.

    @martinmr
    martinmr committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f4244c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Remove unnecessary check.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    514e5e5 View commit details
    Browse the repository at this point in the history

  2. Manish's review. Remove delete splits var in output. Rename some fiel… 

    …ds and funcs.
    @manishrjain
    manishrjain committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    0f13be3 View commit details
    Browse the repository at this point in the history

  3. Fix marshal test.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    2165095 View commit details
    Browse the repository at this point in the history

  4. Do not use out.plist.Splits for iteration.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f7debac View commit details
    Browse the repository at this point in the history

  5. Sort splits after removing empty list parts.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    4c1ded9 View commit details
    Browse the repository at this point in the history

  6. First split should start at 1 instead of zero.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ba74bce View commit details
    Browse the repository at this point in the history

  7. Remove HasStartUid field from ParsedKey.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    b5b6a7f View commit details
    Browse the repository at this point in the history

  8. Remove completed todo.

    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    fb04677 View commit details
    Browse the repository at this point in the history

  9. First split should not be removed unless entire list is empty. 

    Add test to verify this invariant.
    @martinmr
    martinmr committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    30c1799 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Add comment to Rollup

    @martinmr
    martinmr committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    c13b4cb View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    8a18e67 View commit details
    Browse the repository at this point in the history

  3. Fix debug tool.

    @martinmr
    martinmr committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    99cc5cb View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. go fmt.

    @martinmr
    martinmr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    2adc138 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    d818bbe View commit details
    Browse the repository at this point in the history

  3. Copied comment.

    @martinmr
    martinmr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    bca3c05 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    4fb78a6 View commit details
    Browse the repository at this point in the history

  2. Fix comment length.

    @martinmr
    martinmr committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    51786ad View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ad39e3b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Merge remote-tracking branch 'origin/master' into martinmr/multi-part… 

    …-list
    @martinmr
    martinmr committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    81f58f0 View commit details
    Browse the repository at this point in the history

  2. Remove extra file

    @martinmr
    martinmr committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    76e1a54 View commit details
    Browse the repository at this point in the history