Fix an assorted list of goroutine leaks. #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all of these channel allocs multiple goroutines are executed and returned early in case of error. We don't wait for other goroutines to terminate while blocked on sending to the channel.
martinmr
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
codexnull
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
codexnull
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Reviewable status:
manishrjain
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:
manishrjain
pushed a commit
that referenced
this pull request
Apr 11, 2019
In all of these channel allocs multiple goroutines are executed and returned early in case of error. We don't wait for other goroutines to terminate while blocked on sending to the channel.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
In all of these channel allocs multiple goroutines are executed and returned early in case of error. We don't wait for other goroutines to terminate while blocked on sending to the channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all of these channel allocs multiple goroutines are executed and returned early
in case of error. We don't wait for other goroutines to terminate while blocked on
sending to the channel.
This change is