Add minweight and maxweight arguments to k-shortest path algorithms. #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two new arguments allow the filtering of paths that do not meet the mininum and maximum weight requirements. Added unit tests.
Set minweight and maxweight to the minimum and maximum possible float values respectively when they are not passed explicitly.
manishrjain
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
query/query.go, line 801 at r1 (raw file):
} if v, ok := gq.Args["depth"]; ok && (args.Alias == "shortest") {
Would make sense to move all these && args.Alias == "shortest" to one big if condition.
martinmr
commented
Jan 24, 2019
There was a problem hiding this comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
query/query.go, line 801 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Would make sense to move all these
&& args.Alias == "shortest"to one big if condition.
Done.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…graph-io#2915) The two new arguments allow the filtering of paths that do not meet the mininum and maximum weight requirements. Added unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two new arguments allow the filtering of paths that do not meet the
mininum and maximum weight requirements.
Added unit tests.
Fixes #1778
This change is