Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reserved predicates from export. #3529

Closed
MichelDiz opened this issue Jun 6, 2019 · 5 comments
Closed

Remove reserved predicates from export. #3529

MichelDiz opened this issue Jun 6, 2019 · 5 comments
Assignees
@martinmr
Labels
kind/bug Something is broken. kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release.

Comments

@MichelDiz
Copy link
Contributor 

Processing schema file "g01.schema"
Error while processing schema file "g01.schema": rpc error: code = Unknown desc = predicate dgraph.group.acl is reserved and is not allowed to be modified

All Dgraph reserved preds are exported.
@martinmr martinmr self-assigned this Jun 6, 2019
@martinmr
Copy link
Contributor

martinmr commented Jun 6, 2019 •
edited
Loading

How did you run into this error? live loader?

I don't think we should remove reserved predicates from the export (from the data at least) but the schema should be handled better.

@MichelDiz
Copy link
Contributor Author

Yeah, I was in live load. I had to search through the whole schema for which predicates to remove.

@martinmr
Copy link
Contributor

martinmr commented Jun 6, 2019

So there's actually two problems:

  1. Dgraph master was not checking all the reserved preds when acls were disabled, leading it to think the reserved predicate had changed.
  2. I assume the exported schema was exported from version 1.0. This version contains ACL predicates but ACL is not really working there and a few of the reserved predicates are different from their current versions so this will break even after the bug above is fixed.

I am fixing the bug for now but the release/v1.0 branch should be cleaned of the ACL code or it will keep causing issues. This is not the first time an issue happens due to the leftover code.

@martinmr
Copy link
Contributor

martinmr commented Jun 6, 2019

Fix for item 1: #3531

@martinmr martinmr added kind/bug Something is broken. kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release. labels Jun 7, 2019
@martinmr martinmr mentioned this issue Jun 7, 2019
Closed
@martinmr
Copy link
Contributor

This should be fixed now that the ACL code has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinmr martinmr

Labels
kind/bug Something is broken. kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinmr @MichelDiz