Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover ACL code from release/v1.0 branch #3535

Closed
martinmr opened this issue Jun 7, 2019 · 0 comments
Closed

Remove leftover ACL code from release/v1.0 branch #3535

martinmr opened this issue Jun 7, 2019 · 0 comments
Assignees
Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release.

Comments

@martinmr
Copy link
Contributor

martinmr commented Jun 7, 2019

Earlier @MichelDiz was helping a user with #3529. On of the issues is that when exporting from an instance running 1.0.x, the ACL predicates are exported. Since those predicates have changed definitions since they were introduced, an error will occur if someone tries to import that schema into a new version (>= 1.1).

It's not the first time some issue happens because there's ACL code in the release/v1.0 branch but the feature is not complete. I think it's best to remove the ACL code from that branch to avoid future confusion and bugs.

Assigning to @gitlw since he wrote the feature and probably knows best how to do this cleanup.

@martinmr martinmr added kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release. labels Jun 7, 2019
@gitlw gitlw closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. priority/P2 Somehow important but would not block a release.
Development

No branches or pull requests

2 participants