Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calls to fmt.Errorf and errors.Errorf #3449

Closed
martinmr opened this issue May 20, 2019 · 0 comments · Fixed by #3627
Closed

Fix calls to fmt.Errorf and errors.Errorf #3449

martinmr opened this issue May 20, 2019 · 0 comments · Fixed by #3627
Assignees
@martinmr
Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.

Comments

@martinmr
Copy link
Contributor

Calls to this function that pass an error as parameter should call errors.Wrapf.
Calls to fmt.Errorf should be replaced with errors.Errorf
@martinmr martinmr self-assigned this May 20, 2019
@danielmai danielmai added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label May 24, 2019
martinmr added a commit that referenced this issue Jul 3, 2019
@martinmr
Replace fmt.Errorf with errors.Errorf
e99e989 
Fixes #3449
@martinmr martinmr mentioned this issue Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinmr martinmr

Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace fmt.Errorf with errors.Errorf dgraph-io/dgraph
2 participants
@martinmr @danielmai