Fix golint warnings (#3331)

contrib/jepsen/main.go

@@ -241,9 +241,8 @@ func runJepsenTest(test *JepsenTest) int {
 		// Check jepsen source to be sure.
 		if strings.Contains(out.String(), "Analysis invalid") {
 			return TestFail
-		} else {
-			return TestIncomplete
 		}
+		return TestIncomplete
 	}
 	if strings.Contains(out.String(), "Everything looks good!") {
 		return TestPass

dgraph/cmd/live/run.go

@@ -362,9 +362,8 @@ func run() error {
 	totalFiles := len(filesList)
 	if totalFiles == 0 {
 		return fmt.Errorf("No data files found in %s", opt.dataFiles)
-	} else {
-		fmt.Printf("Found %d data file(s) to process\n", totalFiles)
 	}
+	fmt.Printf("Found %d data file(s) to process\n", totalFiles)
 
 	//	x.Check(dgraphClient.NewSyncMarks(filesList))
 	errCh := make(chan error, totalFiles)

posting/list_test.go

@@ -1058,6 +1058,7 @@ func TestMultiPartListWriteToDisk(t *testing.T) {
 
 	require.NoError(t, writePostingListToDisk(kvs))
 	newList, err := getNew(kvs[0].Key, ps)
+	require.NoError(t, err)
 
 	opt := ListOptions{ReadTs: uint64(size) + 1}
 	originalUids, err := originalList.Uids(opt)

x/file.go

@@ -91,15 +91,15 @@ func FindDataFiles(str string, ext []string) []string {
 		x.Check(err)
 
 		if fi.IsDir() {
-			match_fn := func(f string) bool {
+			matchFn := func(f string) bool {
 				for _, e := range ext {
 					if strings.HasSuffix(f, e) {
 						return true
 					}
 				}
 				return false
 			}
-			list = FindFilesFunc(str, match_fn)
+			list = FindFilesFunc(str, matchFn)
 		}
 	}
 

z/client.go

@@ -53,12 +53,12 @@ func init() {
 	var grpcPort int
 
 	getPort := func(envVar string, dfault int) int {
-		if p := os.Getenv(envVar); p == "" {
+		p := os.Getenv(envVar)
+		if p == "" {
 			return dfault
-		} else {
-			port, _ := strconv.Atoi(p)
-			return port
 		}
+		port, _ := strconv.Atoi(p)
+		return port
 	}
 
 	grpcPort = getPort("TEST_PORT_ALPHA", 9180)