Making the stream writer APIs goroutine-safe #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlw
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
golangcibot
reviewed
Aug 1, 2019
ashish-goswami
approved these changes
Aug 1, 2019
manishrjain
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gitlw)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 9, 2019
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
(cherry picked from commit f59246c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding locks around the StreamWriter APIs so that multiple go routines can call the APIs simultaneously without race conditions.
I've verified this change in bulk loader, which used to have RACE condition warnings reported by the race detector. With this change, those warnings are no longer showing up.
This change is