VlogSize to store correct directory name to expvar.Map #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
|
|
jarifibrahim
approved these changes
Aug 1, 2019
|
Will update. I'm waiting for our legal team to answer to the CLA. |
ashish-goswami
approved these changes
Aug 1, 2019
|
The change looks harmless. I'm merging it. Thanks for the PR @burmanm. |
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
(cherry picked from commit 2cd3f4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LSM and ValueLog were stored in the different directories, the metrics stored in the expvar would report incorrectly the directory keyname for value dir.
This change is