Lock log file before munmap #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorgorman
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
|
|
|
Hey @connorgorman thanks for sending the PR. Can you please sign the CLA? |
jarifibrahim
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
|
@connorgorman can you please sign the CLA? We can't merge the PR without the CLA. |
|
Looks like the CLA is signed. So, we should be good to merge this PR if still needed. |
|
@ashish-goswami Please review the PR. |
ashish-goswami
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
As per the comments in the struct, the logFile should be write-locked when closing or unmapping. There is a potential race condition where an iterator could be reading a value and be holding the RLock but the memory will be unmapped via a call to deleteLogFile(lf *logFile) . (cherry picked from commit 7a7dd17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comments in the struct, the logFile should be write-locked when closing or unmapping. There is a potential race condition where an iterator could be reading a value and be holding the RLock but the memory will be unmapped via a call to deleteLogFile(lf *logFile)
This change is