Fix race condition in flushDiscardStats function #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
poonai
approved these changes
Jul 5, 2019
manishrjain
approved these changes
Jul 5, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
benpbrown
pushed a commit
to lightstep/badger
that referenced
this pull request
Oct 25, 2019
A couple of builds failed on teamcity with data race error. See https://teamcity.dgraph.io/viewLog.html?buildId=16131 This PR fixes the data race in `flushDiscardStats` function.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
A couple of builds failed on teamcity with data race error. See https://teamcity.dgraph.io/viewLog.html?buildId=16131 This PR fixes the data race in `flushDiscardStats` function. (cherry picked from commit 5caab82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of builds failed on teamcity with data race error. See https://teamcity.dgraph.io/viewLog.html?buildId=16131&tab=buildResultsDiv&buildTypeId=Badger_UnitTests#testNameId2998050314356001114
This PR fixes the data race in
flushDsicardStatsfunction.This change is