Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replay for LSM entries #1456

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix replay for LSM entries #1456

merged 1 commit into from
Aug 17, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Aug 13, 2020

#1372 tried to fix the replay from start issue but it partially fixed the issue. The head was not being updated in case all the entries are inserted only in the LSM tree.

This Pr fixes it


This change is Reviewable

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)

@jarifibrahim jarifibrahim merged commit 4c8fe7f into master Aug 17, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/replay-fix branch August 17, 2020 11:45
jarifibrahim pushed a commit that referenced this pull request Aug 18, 2020
#1372 tried to fix the `replay from
start` issue but it partially fixed the issue. The head was not being updated
in case all the entries are inserted only in the LSM tree.
This commit fixes it.

(cherry picked from commit 4c8fe7f)
jarifibrahim pushed a commit that referenced this pull request Sep 9, 2020
#1372 tried to fix the `replay from
start` issue but it partially fixed the issue. The head was not being updated
in case all the entries are inserted only in the LSM tree.
This commit fixes it.

(cherry picked from commit 4c8fe7f)
jarifibrahim pushed a commit that referenced this pull request Sep 10, 2020
#1372 tried to fix the `replay from
start` issue but it partially fixed the issue. The head was not being updated
in case all the entries are inserted only in the LSM tree.
This commit fixes it.

(cherry picked from commit 4c8fe7f)
jarifibrahim pushed a commit that referenced this pull request Oct 2, 2020
#1372 tried to fix the `replay from
start` issue but it partially fixed the issue. The head was not being updated
in case all the entries are inserted only in the LSM tree.
This commit fixes it.
mYmNeo pushed a commit to mYmNeo/badger that referenced this pull request Jan 16, 2023
…ph-io#1516)

dgraph-io#1372 tried to fix the `replay from
start` issue but it partially fixed the issue. The head was not being updated
in case all the entries are inserted only in the LSM tree.
This commit fixes it.

(cherry picked from commit 4c8fe7f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants