fix #1280 Sequence generates duplicate values #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
|
|
golangcibot
reviewed
Mar 27, 2020
db.go
Outdated
| return err | ||
| } | ||
|
|
||
| if num == seq.leased{ |
There was a problem hiding this comment.
File is not gofmt-ed with -s (from gofmt)
Suggested change
| if num == seq.leased{ | |
| if num == seq.leased { |
db_test.go
Outdated
| for i:=0;i<5;i++{ | ||
| num2, err := seq3.Next() | ||
| require.NoError(t, err) | ||
| require.NotEqual(t,num,num2) |
There was a problem hiding this comment.
It would be nicer if we test here for the values we expect (3, 4, 5, etc)
jarifibrahim
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @GameXG, @jarifibrahim, and @manishrjain)
manishrjain
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @GameXG, and @jarifibrahim)
NamanJain8
pushed a commit
that referenced
this pull request
Sep 8, 2020
NamanJain8
added a commit
that referenced
this pull request
Sep 9, 2020
Fix issue #1280 (cherry picked from commit fa94030) Co-authored-by: GameXG <[email protected]>
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
) Fix issue dgraph-io#1280 (cherry picked from commit fa94030) Co-authored-by: GameXG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
Sequence may produce duplicate ids. This problem is solved here.
Fixes #1280
This change is