Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Value Checksum success test #1147

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Add Value Checksum success test #1147

merged 4 commits into from
Dec 6, 2019

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Dec 6, 2019 •
edited by manishrjain
Loading

PR #1138 fixed the checksum issue but it was missing a test. This PR adds a test for it.

This change is Reviewable

@jarifibrahim jarifibrahim merged commit 1ee50f7 into master Dec 6, 2019
@jarifibrahim jarifibrahim deleted the ibrahim/valuechecksum-test branch December 6, 2019 11:49
@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 77.573% when pulling 8318a16 on ibrahim/valuechecksum-test into e28642f on master.

jarifibrahim pushed a commit that referenced this pull request Mar 12, 2020
Add Value Checksum success test (#1147)
52a477d 
PR #1138 fixed the checksum
issue but it was missing a test. This PR adds a test for it.

(cherry picked from commit 1ee50f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poonai poonai poonai approved these changes

@ashish-goswami ashish-goswami Awaiting requested review from ashish-goswami

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jarifibrahim @coveralls @poonai @tuesmiddt