Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 32 bit builds on travis #1385

Closed
jarifibrahim opened this issue Jun 25, 2020 · 0 comments · Fixed by #1392
Closed

Support 32 bit builds on travis #1385

jarifibrahim opened this issue Jun 25, 2020 · 0 comments · Fixed by #1392
Labels
area/testing Testing related issues good first issue These are simple issues that can be picked up by new contributors kind/enhancement Something could be better.

Comments

@jarifibrahim
Copy link
Contributor

Badger tests fail on 32 bit systems. We've tried to fix them multiple times but the crashes keep resurfacing. See #1384, #1142, #953, #89 .

#1216 was an attempt to run travis builds on 32 bit systems but travis seems it's run i386 tests on a 64-bit host.
As mentioned in #1384 (comment), it might be possible to run badger builds on a 32 bit container on travis on a 64 bit host and we should do that.

Here's an example of how delve runs 32 bit tests on a container on travis

# 386 linux
jobs:
  include:
    -  os: linux
       services: docker
       env: go_32_version=1.14

script: >-
    if [ $TRAVIS_OS_NAME = "linux" ] && [ $go_32_version ]; then
      docker pull i386/centos:7;
      docker run \
      -v $(pwd):/delve \
      --env TRAVIS=true \
      --env CI=true \
      --privileged i386/centos:7 \
      /bin/bash -c "set -x && \
           cd delve && \
           yum -y update && yum -y upgrade && \
           yum -y install wget make git gcc && \
           wget -q https://dl.google.com/go/go${go_32_version}.linux-386.tar.gz && \
           tar -C /usr/local -xzf go${go_32_version}.linux-386.tar.gz && \
           export PATH=$PATH:/usr/local/go/bin && \
           go version && \
           uname -a && \
           make test";
    else
      make test;
    fi

Taken from https://github.com/chainhelen/delve/blob/master/.travis.yml#L51-L82

@jarifibrahim jarifibrahim added kind/enhancement Something could be better. area/testing Testing related issues good first issue These are simple issues that can be picked up by new contributors labels Jun 25, 2020
jarifibrahim pushed a commit that referenced this issue Jul 2, 2020
This PR enables 32-bit cross compilation on Travis CI. There have been multiple
reports of badger tests failing on 32-bit machines and a 32 bit CI would be
very useful.

This PR creates a new Travis CI job which builds and runs tests on a 32-bit machine.

Fixes #1385
jarifibrahim pushed a commit that referenced this issue Oct 2, 2020
This PR enables 32-bit cross compilation on Travis CI. There have been multiple
reports of badger tests failing on 32-bit machines and a 32 bit CI would be
very useful.

This PR creates a new Travis CI job which builds and runs tests on a 32-bit machine.

Fixes #1385
manishrjain pushed a commit to outcaste-io/outserv that referenced this issue Jul 6, 2022
This PR enables 32-bit cross compilation on Travis CI. There have been multiple
reports of badger tests failing on 32-bit machines and a 32 bit CI would be
very useful.

This PR creates a new Travis CI job which builds and runs tests on a 32-bit machine.

Fixes dgraph-io/badger#1385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues good first issue These are simple issues that can be picked up by new contributors kind/enhancement Something could be better.
Development

Successfully merging a pull request may close this issue.

1 participant