Fix ineffassign warnings. (#1055)

key_registry_test.go

@@ -112,7 +112,7 @@ func TestMismatch(t *testing.T) {
 	_, err = rand.Read(encryptionKey)
 	require.NoError(t, err)
 	opt.EncryptionKey = encryptionKey
-	kr, err = OpenKeyRegistry(opt)
+	_, err = OpenKeyRegistry(opt)
 	require.Error(t, err)
 	require.EqualError(t, err, ErrEncryptionKeyMismatch.Error())
 }

value_test.go

@@ -671,7 +671,7 @@ func TestReadOnlyOpenWithPartialAppendToValueLog(t *testing.T) {
 
 	opts.ReadOnly = true
 	// Badger should fail a read-only open with values to replay
-	kv, err = Open(opts)
+	_, err = Open(opts)
 	require.Error(t, err)
 	require.Regexp(t, "Database was not properly closed, cannot open read-only|Read-only mode is not supported on Windows", err.Error())
 }

y/y_test.go

@@ -222,10 +222,12 @@ func TestPagebufferReader3(t *testing.T) {
 	// Read EOF.
 	n, err = reader.Read(readBuf)
 	require.Equal(t, err, io.EOF, "should return EOF")
+	require.Equal(t, n, 0)
 
 	// Read EOF again.
 	n, err = reader.Read(readBuf)
 	require.Equal(t, err, io.EOF, "should return EOF")
+	require.Equal(t, n, 0)
 }
 
 // Test when read buffer is larger than PageBuffer.
@@ -250,4 +252,5 @@ func TestPagebufferReader4(t *testing.T) {
 	// Read EOF.
 	n, err = reader.Read(readBuf)
 	require.Equal(t, err, io.EOF, "should return EOF")
+	require.Equal(t, n, 0)
 }