build: update to TypeScript 5.6 RC

Updates the repo to the TypeScript 5.6 RC and narrows down the version to drop support for 5.4, in line with the compiler.
dgp1130 · Aug 29, 2024 · 7f570c5 · 7f570c5
1 parent 5226c53
commit 7f570c5
Show file tree

Hide file tree

Showing 12 changed files with 4,898 additions and 3,626 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -8,6 +8,7 @@
 /packages/angular_devkit/schematics_cli/blank/project-files/
 /packages/angular_devkit/schematics_cli/blank/schematic-files/
 /packages/angular_devkit/schematics_cli/schematic/files/
+/packages/schematics/angular/third_party/
 /README.md
 /CONTRIBUTING.md
 .yarn/

diff --git a/goldens/public-api/angular_devkit/core/index.api.md b/goldens/public-api/angular_devkit/core/index.api.md
@@ -386,7 +386,7 @@ interface JsonVisitor {
 
 // @public (undocumented)
 class LevelCapLogger extends LevelTransformLogger {
-    constructor(name: string, parent: Logger | null, levelCap: LogLevel);
+    constructor(name: string, parent: (Logger | null) | undefined, levelCap: LogLevel);
     // (undocumented)
     readonly levelCap: LogLevel;
     // (undocumented)
@@ -403,7 +403,7 @@ class LevelCapLogger extends LevelTransformLogger {
 
 // @public (undocumented)
 class LevelTransformLogger extends Logger {
-    constructor(name: string, parent: Logger | null, levelTransform: (level: LogLevel) => LogLevel);
+    constructor(name: string, parent: (Logger | null) | undefined, levelTransform: (level: LogLevel) => LogLevel);
     // (undocumented)
     createChild(name: string): Logger;
     // (undocumented)
@@ -553,7 +553,7 @@ function parseJsonPointer(pointer: JsonPointer): string[];
 // @public (undocumented)
 export class PartiallyOrderedSet<T> implements Set<T> {
     // (undocumented)
-    [Symbol.iterator](): Generator<T, void, unknown>;
+    [Symbol.iterator](): Generator<T, undefined, unknown>;
     // (undocumented)
     get [Symbol.toStringTag](): 'Set';
     // (undocumented)

diff --git a/package.json b/package.json
@@ -198,7 +198,7 @@
     "tree-kill": "1.2.2",
     "ts-node": "^10.9.1",
     "tslib": "2.7.0",
-    "typescript": "5.5.4",
+    "typescript": "5.6.1-rc",
     "undici": "6.19.8",
     "unenv": "^1.10.0",
     "verdaccio": "5.32.1",

diff --git a/packages/angular/build/package.json b/packages/angular/build/package.json
@@ -53,7 +53,7 @@
     "less": "^4.2.0",
     "postcss": "^8.4.0",
     "tailwindcss": "^2.0.0 || ^3.0.0",
-    "typescript": ">=5.4 <5.6"
+    "typescript": ">=5.5 <5.7"
   },
   "peerDependenciesMeta": {
     "@angular/localize": {

diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json
@@ -89,7 +89,7 @@
     "ng-packagr": "^19.0.0-next.0",
     "protractor": "^7.0.0",
     "tailwindcss": "^2.0.0 || ^3.0.0",
-    "typescript": ">=5.4 <5.6"
+    "typescript": ">=5.5 <5.7"
   },
   "peerDependenciesMeta": {
     "@angular/localize": {

diff --git a/packages/angular_devkit/core/src/utils/partially-ordered-set.ts b/packages/angular_devkit/core/src/utils/partially-ordered-set.ts
@@ -157,6 +157,8 @@ export class PartiallyOrderedSet<T> implements Set<T> {
         throw new CircularDependencyFoundException();
       }
     }
+
+    return undefined;
   }
 
   get [Symbol.toStringTag](): 'Set' {

diff --git a/packages/angular_devkit/schematics/src/tree/action.ts b/packages/angular_devkit/schematics/src/tree/action.ts
@@ -150,7 +150,7 @@ export class ActionList implements Iterable<Action> {
   get length() {
     return this._actions.length;
   }
-  [Symbol.iterator]() {
+  [Symbol.iterator](): IterableIterator<Action> {
     return this._actions[Symbol.iterator]();
   }
 }

diff --git a/packages/ngtools/webpack/package.json b/packages/ngtools/webpack/package.json
@@ -22,14 +22,14 @@
   "homepage": "https://github.com/angular/angular-cli/tree/main/packages/ngtools/webpack",
   "peerDependencies": {
     "@angular/compiler-cli": "^19.0.0-next.0",
-    "typescript": ">=5.4 <5.6",
+    "typescript": ">=5.5 <5.7",
     "webpack": "^5.54.0"
   },
   "devDependencies": {
     "@angular-devkit/core": "0.0.0-PLACEHOLDER",
     "@angular/compiler": "19.0.0-next.2",
     "@angular/compiler-cli": "19.0.0-next.2",
-    "typescript": "5.5.4",
+    "typescript": "5.6.1-rc",
     "webpack": "5.94.0"
   }
 }
diff --git a/packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/BUILD.bazel b/packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/BUILD.bazel
@@ -1,11 +1,11 @@
 load("//tools:defaults.bzl", "ts_library")
 
-# files fetched on 2024-07-02 from
-# https://github.com/microsoft/TypeScript/releases/tag/v5.5.2
+# files fetched on 2024-09-29 from
+# https://github.com/microsoft/TypeScript/releases/tag/v5.6-rc
 
 # Commands to download:
-# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.5.2/lib/typescript.d.ts -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.d.ts
-# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.5.2/lib/typescript.js -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.js
+# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.6-rc/lib/typescript.d.ts -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.d.ts
+# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.6-rc/lib/typescript.js -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.js
 
 licenses(["notice"])  # Apache 2.0
-Original file line number
+Diff line change
@@ Expand Up / @@ -157,6 +157,8 @@ export class PartiallyOrderedSet<T> implements Set<T> { @@
             throw new CircularDependencyFoundException();
           }
         }
+        return undefined;
       }
       get [Symbol.toStringTag](): 'Set' {
@@ Expand Down @@