Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy from SETUP_REQUIRES #427

Merged
merged 1 commit into from
May 5, 2022
Merged

Remove NumPy from SETUP_REQUIRES #427

merged 1 commit into from
May 5, 2022

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented May 5, 2022

Closes #426

@BastianZim BastianZim marked this pull request as ready for review May 5, 2022 13:32
@dfm
Copy link
Owner

dfm commented May 5, 2022

Looks good and the build works. Thanks!

@dfm dfm merged commit 564228e into dfm:main May 5, 2022
@BastianZim BastianZim deleted the patch-1 branch May 5, 2022 16:17
@BastianZim
Copy link
Contributor Author

BastianZim commented May 5, 2022

@dfm Thanks for merging! Any chance you can release a new version with that? I'd need this downstream.

@dfm
Copy link
Owner

dfm commented May 10, 2022

Whoops yes - absolutely! I'll do that now.

@BastianZim
Copy link
Contributor Author

Thank you!

@dfm
Copy link
Owner

dfm commented May 10, 2022

@BastianZim
Copy link
Contributor Author

BastianZim commented May 10, 2022

Thank you! Although I actually need the conda-forge version :)

But the bots should do that in a couple of hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is numpy required for SETUP_REQUIRES
2 participants