Added functionality to give a description in the progress bar #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! What about adding a |
for more information, see https://pre-commit.ci
|
That is a cleaner way. I have put it in like this, happy to know your thoughts. |
|
Looks good to me! Thanks!! |
|
@dfm could I be a pest and ask for a pypi release with this feature? I can't get my package onto pypi currently as it requires this feature and pypi doesn't like direct dependencies to git repos apparently. |
|
Absolutely! I'll do that now. |
|
v3.1.1 should be on PyPI shortly (as soon as this finishes running) |
|
Amazing! Thanks for your help 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdmallows a description to be given to the progress bar, I find this is helpful in packages where multiple different progress bars are used. This PR allows a description to be added to aemceeprogress bar based on a string passed to to thesamplefunction.