Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new generator - character #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

merddyin
Copy link

@merddyin merddyin commented Apr 7, 2023

Add new base generator and associated tests
Name: character
Purpose: Generates a single symbol, number, or alpha character in either upper or lower case. Will be used by a planned new generator for creation of complex passwords.

@merddyin
Copy link
Author

merddyin commented Apr 7, 2023

Additional notes:
Generator has no supplemental data file dependencies
Associated tests cover all available parameters and value combinations (13 tests, with 13 of 13 passing locally)
Tests have been run in both PowerShell 7.3.3 and Windows PowerShell 5.1 on Windows 11

@dfinke dfinke self-assigned this Apr 8, 2023
@dfinke
Copy link
Owner

dfinke commented Apr 8, 2023

TBH, not sure when I'll be able to get to this. Between new stuff and tests its >300 loc.

Plus, I need to re-orient myself on the functionality in the psm1.

@merddyin
Copy link
Author

Understood, though I'd point out that, if you take out all the comments (including the comment-based help), the actual function is barely 100 lines in total...less if you also dump the five Write-Verbose lines. From a tests perspective, I modeled mine after your own tests, though I did add tests for return type that your tests don't currently have. I picked this as the first PR because it was simple...it returns a single item, doesn't depend on other generators, and doesn't have any advanced output.

I guess, just let me know when you are ready to dig in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants