-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use openssl_3_0
and niv update
all deps
#50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kritzcreek feel free to ignore the review request! |
to install-nix-action@v17
checkout@v3
@kentosugama I'd be glad to walk you through all of these commits explaining what they do and what they are good for. |
matthewhammer
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
chenyan-dfinity
approved these changes
Jun 21, 2022
@ggreif Thanks Gabor! Can I get a raincheck on this and ask you after I get to reading through the repos? |
I am not the owner of the repos, but I have done 2 releases, and can
comment on the commits in this PR (only) :-)
…On 6/21/22, kentosugama ***@***.***> wrote:
@ggreif Thanks Gabor! Can I get a raincheck on this and ask you after I get
to reading through the repos?
--
Reply to this email directly or view it on GitHub:
#50 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that recent Ubuntu distros don't include
openssl-1.1.1
by default any more (fixes #48), this PR adopts 3.0.v3.0 of
openssl
has been released on 8 Sept 2021, so it should be widespread enough in recent distributions.Also bumps:
nix
deps (e.g.release-22.05
)cargo
deps