Skip to content

Commit

Permalink
fix: for publish-manifest workflow failure starting 2022-12-12
Browse files Browse the repository at this point in the history
Example failed workflow: https://github.com/dfinity/sdk/actions/runs/3697173489/jobs/6262516972

This is the change to shfmt 3.6.0: mvdan/sh#849
  - Simplify ${name:-} to the equivalent ${name-} - #849
  • Loading branch information
ericswanson-dfinity committed Dec 14, 2022
1 parent 624477a commit 33f5d40
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions public/install/999_footer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ SDK_WEBSITE="https://sdk.dfinity.org"
DFX_RELEASE_ROOT="${DFX_RELEASE_ROOT:-$SDK_WEBSITE/downloads/dfx}"
DFX_GITHUB_RELEASE_ROOT="${DFX_GITHUB_RELEASE_ROOT:-https://github.com/dfinity/sdk/releases/download}"
DFX_MANIFEST_JSON_URL="${DFX_MANIFEST_JSON_URL:-$SDK_WEBSITE/manifest.json}"
DFX_VERSION="${DFX_VERSION:-}"
DFX_VERSION="${DFX_VERSION-}"

# The SHA and the time of the last commit that touched this file.
SCRIPT_COMMIT_DESC="@revision@"
Expand Down Expand Up @@ -60,7 +60,7 @@ validate_install_dir() {
}

sdk_install_dir() {
if [ "${DFX_INSTALL_ROOT:-}" ]; then
if [ "${DFX_INSTALL_ROOT-}" ]; then
# If user specifies an actual dir, use that.
validate_install_dir "${DFX_INSTALL_ROOT}"
printf %s "${DFX_INSTALL_ROOT}"
Expand Down

0 comments on commit 33f5d40

Please sign in to comment.