Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix request export order #449

Conversation

olaszakos
Copy link
Contributor

@olaszakos olaszakos commented Dec 2, 2024

  • implements the sort_by optional field for GetNextApprovableRequestInput to be able to affect the order it will produce the next approvable request
  • removes the extra sorting on the frontend for csv export generation that will put the results in reverse order
  • bug fix: list_requests with only_approvable = true could return non-pending requests for users who could approve if the request was still pending

Manual testing findings:

  1. Uploaded CSV file for batch transfers. The transfers are created from the frontend 10 in parallel at a time. The creation order inside a batch of 10 is random. The batch transfer feature therefore will create a list of transfers that dont keep the ordering of the original CSV input file.
  2. Exporting the created transfers will produce a list that is sorted from most recent to oldest. This is in line with the ordering of the data table on the frontend.
  3. Using the load-next button will enumerate the pending requests in the same order as in the exported CSV file. However if you start approving from the middle of the list, the next approvable request will jump back to the first one in the list.

@olaszakos olaszakos requested a review from a team as a code owner December 2, 2024 10:24
@olaszakos olaszakos merged commit 9499203 into main Dec 3, 2024
23 checks passed
@olaszakos olaszakos deleted the PEN-381-order-for-load-next-approvable-request-should-match-list-request-order branch December 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants