Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Remove main nav items in user menu #4957

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

daviddecentage
Copy link
Collaborator

Motivation

This PR should be merged right after #4955.

Since #4955 adds a dedicated mobile bottom bar menu, we dont rely on the top right menu anymore, as Desktop has the regular left pane menu and mobile the new dedicated bottom bar. Therefor we remove the main navigation items in the popover menu.

Changes

Removed main navigation itms from Menu component

@daviddecentage daviddecentage marked this pull request as ready for review March 10, 2025 13:17
@daviddecentage daviddecentage requested a review from a team as a code owner March 10, 2025 13:17
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the E2E tests still work? IIRC they use this menu to navigate

Copy link
Collaborator

@inc-man inc-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of the E2E stuff for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants