Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): explicit type in solanaHttpRpc #4098

Merged
merged 4 commits into from
Jan 8, 2025
Merged

refactor(frontend): explicit type in solanaHttpRpc #4098

merged 4 commits into from
Jan 8, 2025

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

We put the explicit type for the util solanaHttpRpc and we decompose the logic.

@AntonioVentilii AntonioVentilii requested a review from a team as a code owner January 7, 2025 12:16
loki344
loki344 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@loki344 loki344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) January 8, 2025 08:23
@AntonioVentilii AntonioVentilii merged commit 5d4e530 into main Jan 8, 2025
21 checks passed
@AntonioVentilii AntonioVentilii deleted the refactor(frontend)/explicit-type-in-solanaHttpRpc branch January 8, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loki344 loki344 loki344 approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii @loki344