feat(frontend): implements reward canister api #3996
Merged
+328
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I randomly noticed this PR. Not sure if it's a general work in progress or effective implementation of a feature so just a heads-up: canister, API, and services should be provided in separate PRs, each covered by tests. |
|
@peterpeterparker atm it's just work in progress. But good to know, if it is finished, i will split them into different PRs |
…lements-reward-canister-api
…re(frontend)/implements-reward-canister-api
…lements-reward-canister-api # Conflicts: # src/frontend/src/lib/canisters/reward.canister.ts # src/frontend/src/tests/lib/canisters/reward.canister.spec.ts
|
@peterpeterparker now this PR is open and ready to be reviewed |
…lements-reward-canister-api # Conflicts: # src/frontend/src/lib/i18n/en.json # src/frontend/src/lib/types/i18n.d.ts
peterpeterparker
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
LGTM, thx
Reviewed offline together with @BonomoAlessandro. Few minor improvements will be provided within this PR after this approval as discussed to move forward.
adds a small doc to the update functions
…lements-reward-canister-api # Conflicts: # src/frontend/src/lib/i18n/en.json
BonomoAlessandro
deleted the
feature(frontend)/implements-reward-canister-api
branch
peterpeterparker
added a commit
that referenced
this pull request
Jan 7, 2025
# Motivation I reviewed the `reward-code.services` after merging #3996 and noticed a few areas that could be better aligned with the codebase's style and patterns for consistency. # Changes for Consistency - Add JSDoc comments for exported functions. - Use specific error classes instead of the generic `Error` when the error type is known. - Bubble the `err` in the `ResultSuccess` return to potentially inform the consumer about which error occurred. - Align the pattern of `updateVipReward` with the pattern of other internal functions in the service, `updateReward`, which throws errors instead of returning values. - Define `err` as `err: unknown`. # Opinionated Changes - Destructure parameters. # TODO - Add a TODO for `getNewReward` to use a `ResultSuccess` return type as well. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use the
reward canister apiand thereward serviceso that we can send some rewards to new or existing users.Changes