-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): Skeleton binding crates #3866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
commented
Dec 17, 2024
DenysKarmazynDFINITY
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like comprehensive pocket-ic tests for Oisy.
To that end, we would like to generate canister bindings to be used in pocket-ic tests rather than maintaining the bindings manually. We will start with the ledger bindings, then move on to the chain fusion signer and rewards canisters.
There already bindings for use inside a canister. There is a TODO to autogenerate them.
However it is inconvenient and sometimes very confusing if the API types are generated twice, with identical names. We will therefore make
didc
generate a file with just Rust types, and the two (pocket-ic and canister) bindings will use those shared types.A further constraint is that pocket-ic and canister bindings cannot be compiled together into the same crate. We therefore need three separate crates for types, pocket-ic bindings and internal canister bindings.
There is quite a lot to do here, so we break it down into small steps.
Changes
Tests