Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed 'address' to 'destination' in i18n error text #1345

Merged
merged 1 commit into from
May 24, 2024
+4 −4
Merged

chore: changed 'address' to 'destination' in i18n error text #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/frontend/src/icp/services/ic-send.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const sendIcrc = async ({

// UI validates addresses and disable form if not compliant. Therefore, this issue should unlikely happen.
if (!validIcrcAddress) {
throw new Error(get(i18n).send.error.invalid_address);
throw new Error(get(i18n).send.error.invalid_destination);
}

progress(SendIcStep.SEND);
Expand All @@ -125,7 +125,7 @@ const sendIcp = async ({

// UI validates addresses and disable form if not compliant. Therefore, this issue should unlikely happen.
if (!validIcrcAddress && !validIcpAddress) {
throw new Error(get(i18n).send.error.invalid_address);
throw new Error(get(i18n).send.error.invalid_destination);
}

progress(SendIcStep.SEND);
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/lib/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@
"erc20_data_undefined": "Erc20 transaction Data cannot be undefined or null.",
"data_undefined": "Transaction Data cannot be undefined or null.",
"no_identity_calculate_fee": "No identity provided to calculate the fee for its principal.",
"invalid_address": "The address is invalid. Please try again with a valid address identifier."
"invalid_destination": "The destination is invalid. Please try again with a valid wallet address or destination."
}
},
"convert": {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/lib/types/i18n.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ interface I18nSend {
erc20_data_undefined: string;
data_undefined: string;
no_identity_calculate_fee: string;
invalid_address: string;
invalid_destination: string;
};
}

Expand Down