feat(backend): record custom user ICRC tokens #1037
Merged
+310
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
approved these changes
Apr 8, 2024
|
|
||
| mutate_state(|s| remove_from_user_token(stored_principal, &mut s.user_custom_token, &find)); | ||
| } | ||
|
|
There was a problem hiding this comment.
I personally would make the query below a certified query but I see that it is the same as the query above. And who knows, there are shiny new certification methods coming that don't require you to keep all your data in a merkle tree!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to how users interact with ERC20 tokens, we aim to provide the capability to add, remove, and list ICRC tokens. Considering the differences between these token types, we've introduced a new storage mechanism tailored for a stable, yet more generic structure. This decision anticipates the potential to support additional token types in the future. Consequently, we may consider migrating existing ERC20 tokens into this new, more adaptable map.
Feature
UserToken, structIcrcTokenand implementation for equality purpose when adding or removing entryUserTokenIdto be able to identity token uniquely