refactor(frontend): consolidate status texts for txns

dfinity · Jan 8, 2025 · b0c1a80 · b0c1a80
1 parent f5d451f
commit b0c1a80
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/src/frontend/src/btc/components/transactions/BtcTransactionModal.svelte b/src/frontend/src/btc/components/transactions/BtcTransactionModal.svelte
@@ -72,12 +72,6 @@
 
 	<Value ref="status" slot="transaction-status">
 		<svelte:fragment slot="label">{$i18n.transaction.text.status}</svelte:fragment>
-		{`${
-			status === 'pending'
-				? $i18n.transaction.text.pending
-				: status === 'unconfirmed'
-					? $i18n.transaction.text.unconfirmed
-					: $i18n.transaction.text.confirmed
-		}`}
+		{`${$i18n.transaction.status[status]}`}
 	</Value>
 </TransactionModal>
diff --git a/src/frontend/src/lib/i18n/en.json b/src/frontend/src/lib/i18n/en.json
@@ -659,16 +659,16 @@
 			"to_copied": "To address copied to clipboard.",
 			"block": "Block",
 			"interacted_with": "Interacted With (To)",
-			"pending": "Pending...",
-			"unconfirmed": "Unconfirmed",
-			"confirmed": "Confirmed",
 			"status": "Status",
 			"confirmations": "Confirmations"
 		},
 		"status": {
+			"confirmed": "Confirmed",
 			"included": "Included",
+			"finalised": "Finalised",
+			"pending": "Pending...",
 			"safe": "Safe",
-			"finalised": "Finalised"
+			"unconfirmed": "Unconfirmed"
 		},
 		"label": {
 			"reimbursement": "Reimbursement",

diff --git a/src/frontend/src/lib/types/i18n.d.ts b/src/frontend/src/lib/types/i18n.d.ts
@@ -588,13 +588,17 @@ interface I18nTransaction {
 		to_copied: string;
 		block: string;
 		interacted_with: string;
-		pending: string;
-		unconfirmed: string;
-		confirmed: string;
 		status: string;
 		confirmations: string;
 	};
-	status: { included: string; safe: string; finalised: string };
+	status: {
+		confirmed: string;
+		included: string;
+		finalised: string;
+		pending: string;
+		safe: string;
+		unconfirmed: string;
+	};
 	label: {
 		reimbursement: string;
 		twin_token_sent: string;