bot: Bump gix-components and ic-js #6129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pr-automation-bot-public[bot]](https://avatars.githubusercontent.com/u/59101585?s=60&v=4){kind=small}
pr-automation-bot-public
bot
requested review from
dskloetd,
mstrasinskis and
yhabib
|
Test pr. |
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
# Motivation The action “Update next npm package dependencies” fails (https://github.com/dfinity/nns-dapp/actions/runs/12467261316) due to an incompatible NPM version, provided by `npm install -g npm@latest`. To resolve the issue, we set up Node.js using the version specified in the .nvmrc file, relying on the fact that each Node.js release comes bundled with a specific npm version. # Changes - Remove `npm install -g npm@latest` (actual fix). - Setup node with the `.nvmrc` file version (to make the action more future proof). # Tests - Ran the action using the branch version that successfully created a PR -- #6129. # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to pull in the latest changes.
This PR was requested by mstrasinskis.
Changes
npm run update:gixnpm run upgrade:nextTests