SECFIND-244: Add notifyAndAttachCanister to canisters API #6126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to recover from interrupted canister creation in the frontend code.
To do this we should be able to notify the CMC and attach a canister without first making a transfer, as the transfer has already happened before the process got interrupted.
See this doc for details.
Changes
notifyAndAttachCanister
which can be used to recover canister creation based on an existing ICP transfer.Tests
setTimeout
and not mockingconsole.log
as nothing gets logged and this just makes debugging harder.Todos
not yet