Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECFIND-244: Set block_index when attaching created canister #6118

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Jan 8, 2025

Motivation

We want to store the block index of the funding transaction for created canisters.
See this doc for details.

Changes

  1. Add block_index to canister details in frontend candid.
  2. Add blockIndex in canister API.
  3. Specify blockIndex from the transaction when attaching a created canister.

Tests

  1. Unit tests updated.
  2. Tested manually in a branch with more end-to-end changes.

Todos

  • Add entry to changelog (if necessary).
    not yet

@dskloetd dskloetd marked this pull request as ready for review January 8, 2025 10:56
@dskloetd dskloetd requested a review from a team as a code owner January 8, 2025 10:56
@dskloetd dskloetd enabled auto-merge January 8, 2025 10:56
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dskloetd dskloetd added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@dskloetd dskloetd added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@dskloetd dskloetd added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit b932206 Jan 8, 2025
31 checks passed
@dskloetd dskloetd deleted the kloet/fe-block-index branch January 8, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants