Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuron confirm following confirmation #6115

Merged
merged 15 commits into from
Jan 8, 2025

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Jan 7, 2025

Motivation

To provide users with a clearer understanding of what they are confirming, we need to display the confirmation dialog, including the current following state, on the neuron detail page when they click ‘Confirm Following’ (using the same dialog as in the LosingRewardsBanner).

Changes

  • Add clickable prop to NnsLosingRewardsNeuronCard to support not clickable neuron cards.
  • Add LosingRewardNeuronsModal to available NNS neuron modals.
  • Display LosingRewardNeuronsModal instead of calling refreshVotingPower.
  • Minor text changes.

Tests

  • Move "call refreshVotingPower" test from NnsNeuronRewardStatusAction.spec to NnsNeuronDetail.spec.
  • Tested locally that it works.
confirmation.mov

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review January 7, 2025 17:44
@mstrasinskis mstrasinskis requested a review from a team as a code owner January 7, 2025 17:44
@mstrasinskis mstrasinskis added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 36373c9 Jan 8, 2025
31 checks passed
@mstrasinskis mstrasinskis deleted the neuron-confirm-following-confirmation branch January 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants