-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuron confirm following confirmation #6115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/lib/modals/neurons/LosingRewardNeuronsModal.svelte
dskloetd
approved these changes
Jan 8, 2025
yhabib
reviewed
Jan 8, 2025
frontend/src/lib/modals/neurons/LosingRewardNeuronsModal.svelte
Outdated
Show resolved
Hide resolved
yhabib
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To provide users with a clearer understanding of what they are confirming, we need to display the confirmation dialog, including the current following state, on the neuron detail page when they click ‘Confirm Following’ (using the same dialog as in the LosingRewardsBanner).
Changes
clickable
prop to NnsLosingRewardsNeuronCard to support not clickable neuron cards.LosingRewardNeuronsModal
to available NNS neuron modals.LosingRewardNeuronsModal
instead of callingrefreshVotingPower
.Tests
NnsNeuronRewardStatusAction.spec
toNnsNeuronDetail.spec
.confirmation.mov
Todos
Not necessary.