Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ENABLE_PERIODIC_FOLLOWING_CONFIRMATION #6106

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Enable ENABLE_PERIODIC_FOLLOWING_CONFIRMATION #6106

merged 4 commits into from
Jan 8, 2025

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Jan 6, 2025 •
edited
Loading

Motivation

We want to remind participants to review their following or vote manually to avoid missing rewards

Changes

  • Enable ENABLE_PERIODIC_FOLLOWING_CONFIRMATION.
  • Ran ./scripts/nns-dapp/test-config --update to update golden config files.

Tests

  • Tested during implementation.
  • Tested locally that the feature flag is enabled.

Todos

  • Add entry to changelog (if necessary).

@mstrasinskis mstrasinskis marked this pull request as ready for review January 8, 2025 09:56
@mstrasinskis mstrasinskis requested a review from a team as a code owner January 8, 2025 09:56
yhabib
yhabib approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@mstrasinskis mstrasinskis added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 47eccac Jan 8, 2025
31 checks passed
@mstrasinskis mstrasinskis deleted the enable_ENABLE_PERIODIC_FOLLOWING_CONFIRMATION branch January 8, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstrasinskis @yhabib @dskloetd