Fix errors logged in SnsProposalDetail.spec.ts

frontend/src/tests/fakes/sns-governance-api.fake.ts

@@ -322,7 +322,7 @@ async function queryProposal({
 }): Promise<SnsProposalData> {
   const proposal = proposals
     .get(mapKey({ identity, rootCanisterId }))
-    .proposals.find(({ id }) => fromNullable(id).id === proposalId.id);
+    ?.proposals.find(({ id }) => fromNullable(id).id === proposalId.id);
   if (isNullish(proposal)) {
     throw new SnsGovernanceError(
       `No proposal for given proposalId ${proposalId.id}`

frontend/src/tests/lib/pages/SnsProposalDetail.spec.ts

@@ -79,7 +79,6 @@ describe("SnsProposalDetail", () => {
 
   describe("not logged in", () => {
     beforeEach(() => {
-      vi.spyOn(console, "error").mockImplementation(() => undefined);
       setNoIdentity();
       page.mock({ data: { universe: rootCanisterId.toText() } });
       setSnsProjects([
@@ -210,6 +209,7 @@ describe("SnsProposalDetail", () => {
     });
 
     it("should redirect to the list of sns proposals if proposal is not found", async () => {
+      vi.spyOn(console, "error").mockReturnValue();
       // There is no proposal with id 2 in the fake implementation.
       // Therefore, the page should redirect to the list of proposals.
       render(SnsProposalDetail, {
@@ -221,6 +221,12 @@ describe("SnsProposalDetail", () => {
         const { path } = get(pageStore);
         return expect(path).toEqual(AppPath.Proposals);
       });
+      expect(console.error).toBeCalledWith(
+        expect.objectContaining({
+          error: new Error("No proposal for given proposalId 2"),
+        })
+      );
+      expect(console.error).toBeCalledTimes(1);
     });
 
     it("should not render content if universe changes to Nns", async () => {
@@ -401,6 +407,7 @@ describe("SnsProposalDetail", () => {
     });
 
     it("should navigate to the proposal from the next Sns", async () => {
+      vi.spyOn(console, "error").mockReturnValue();
       mockCommittedSnsProjectsWithVotableProposals([
         { rootCanisterId: principal1, proposalIds: [20n, 19n] },
         { rootCanisterId: principal2, proposalIds: [30n, 29n] },
@@ -433,9 +440,32 @@ describe("SnsProposalDetail", () => {
           id: "/(app)/proposal/",
         },
       });
+
+      await runResolvedPromises();
+      // The navigation changes both the proposal ID and the universe.
+      // In reality this will cause a navigation and a new component will be
+      // rendered with the new proposal ID and universe.
+      // But in the test, the component notices the change in universe (because
+      // it comes from the store) but not the change in proposal ID (because
+      // it's passed in as a prop). So it tries to load proposal 19 from the
+      // wrong universe, which causes these errors.
+      expect(console.error).toHaveBeenNthCalledWith(
+        2,
+        expect.objectContaining({
+          error: new Error("No proposal for given proposalId 19"),
+        })
+      );
+      expect(console.error).toHaveBeenNthCalledWith(
+        1,
+        expect.objectContaining({
+          error: new Error("No proposal for given proposalId 19"),
+        })
+      );
+      expect(console.error).toBeCalledTimes(2);
     });
 
     it("should navigate to the proposal from the previous Sns", async () => {
+      vi.spyOn(console, "error").mockReturnValue();
       mockCommittedSnsProjectsWithVotableProposals([
         { rootCanisterId: principal1, proposalIds: [20n, 19n] },
         { rootCanisterId: principal2, proposalIds: [30n, 29n] },
@@ -468,12 +498,33 @@ describe("SnsProposalDetail", () => {
           id: "/(app)/proposal/",
         },
       });
+
+      await runResolvedPromises();
+      // The navigation changes both the proposal ID and the universe.
+      // In reality this will cause a navigation and a new component will be
+      // rendered with the new proposal ID and universe.
+      // But in the test, the component notices the change in universe (because
+      // it comes from the store) but not the change in proposal ID (because
+      // it's passed in as a prop). So it tries to load proposal 30 from the
+      // wrong universe, which causes these errors.
+      expect(console.error).toHaveBeenNthCalledWith(
+        2,
+        expect.objectContaining({
+          error: new Error("No proposal for given proposalId 30"),
+        })
+      );
+      expect(console.error).toHaveBeenNthCalledWith(
+        1,
+        expect.objectContaining({
+          error: new Error("No proposal for given proposalId 30"),
+        })
+      );
+      expect(console.error).toBeCalledTimes(2);
     });
   });
 
   describe("not logged in that logs in afterwards", () => {
     beforeEach(() => {
-      vi.spyOn(console, "error").mockImplementation(() => undefined);
       page.mock({ data: { universe: rootCanisterId.toText() } });
     });
 
@@ -527,6 +578,23 @@ describe("SnsProposalDetail", () => {
         ],
       });
 
+      fakeSnsGovernanceApi.addProposalWith({
+        identity: mockIdentity,
+        rootCanisterId,
+        ...proposal,
+        proposal_creation_timestamp_seconds: proposalCreatedTimestamp,
+        ballots: [
+          [
+            getSnsNeuronIdAsHexString(mockSnsNeuron),
+            {
+              vote: SnsVote.Unspecified,
+              voting_power: 100_000_000n,
+              cast_timestamp_seconds: 0n,
+            },
+          ],
+        ],
+      });
+
       const { container } = render(SnsProposalDetail, {
         props: {
           proposalIdText: proposalId.id.toString(),

frontend/src/tests/utils/console.test-utils.ts

@@ -1,3 +1,5 @@
+import { runResolvedPromises } from "$tests/utils/timers.test-utils";
+
 type LogType = "log" | "debug" | "warn" | "error";
 
 const logTypes: LogType[] = ["log", "debug", "warn", "error"];
@@ -22,7 +24,8 @@ export const failTestsThatLogToConsole = () => {
     gotLogs = false;
   });
 
-  afterEach(() => {
+  afterEach(async () => {
+    await runResolvedPromises();
     if (!isLoggingAllowed && gotLogs) {
       throw new Error(
         "Your test produced console logs, which is not allowed.\n" +