Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump wasm dependency to v1.1 #1032

Merged
merged 5 commits into from
Dec 16, 2019
Merged

Bump wasm dependency to v1.1 #1032

merged 5 commits into from
Dec 16, 2019

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 16, 2019

this prepares for #1000

This rips out multi-value support in our serializer/parser.

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Dec 16, 2019
@nomeata
Bump wasm dependency to v1.1
5456e57 
this prepares for #1000

This rips out multi-value support in our serializer/parser.
@nomeata
Special stack_type encoding/decoding
32e4536
@nomeata nomeata requested a review from ggreif December 16, 2019 14:17
@nomeata nomeata mentioned this pull request Dec 16, 2019
Merged
ggreif
ggreif reviewed Dec 16, 2019
View reviewed changes
nix/ocaml-wasm.nix Outdated Show resolved Hide resolved
ggreif
ggreif approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I especially liked ValBlockType going away!

@ggreif ggreif removed the automerge-squash When ready, merge (using squash) label Dec 16, 2019
@ggreif
Copy link
Contributor

ggreif commented Dec 16, 2019

So now moc -multi-value won't work until we get wasm-1.x ?

@nomeata @ggreif
Update nix/ocaml-wasm.nix
e2970de 
Co-Authored-By: Gabor Greif <[email protected]>
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 16, 2019

So now moc -multi-value won't work until we get wasm-1.x ?

Until it becomes offiical and is supported by wasm, yes.

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Dec 16, 2019
@mergify mergify bot merged commit acae13f into master Dec 16, 2019
@mergify mergify bot deleted the joachim/wasm-v1.1 branch December 16, 2019 23:27
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Dec 16, 2019
@ggreif
Copy link
Contributor

ggreif commented Dec 16, 2019

So now moc -multi-value won't work until we get wasm-1.x ?

Until it becomes offiical and is supported by wasm, yes.

Should we suppress those options, then?

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 17, 2019

Should we suppress those options, then?

Good idea, feel free to open a PR

@ggreif ggreif mentioned this pull request Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @ggreif