feat(nns): list_neurons supports querying by subaccount #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
e735184 to
16a14b2
Compare
max-dfinity
changed the title
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
3411732 to
93436e7
Compare
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
afe31d5 to
504cc42
Compare
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
4 times, most recently
from
b6966e7 to
b1715d5
Compare
max-dfinity
commented
Feb 4, 2025
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
51a24cf to
4862e0f
Compare
jasonz-dfinity
approved these changes
Feb 4, 2025
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
4862e0f to
1c31fb2
Compare
max-dfinity
force-pushed
the
msum/neurons-by-subaccounts
branch
from
fa00814 to
d95b9fb
Compare
fsodre
approved these changes
Feb 5, 2025
basvandijk
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This allows users who know the subaccounts of their neurons (i.e. they know the nonce and the principal used when the neurons are created) to specify which neurons they would like to list without needing to know the neuron ids (which are generated at random).
What
This adds a new API field to
list_neuronscalledneuron_subaccounts, which works in the same way thatneuron_idsworks. By specifying which subaccounts the user would like to list, they are able to retrieve neurons in the same way that they also can provide neuron ids. Both of these are compatible, and in the case of overlaps, no duplicates are returned.