-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ckbtc): remove distribute_kyt_fee and reimburse_failed_kyt #3325
Conversation
e759059
to
7d3f7ac
Compare
7d3f7ac
to
9e0c23e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit: could we deprecate the DistributedKytFee
event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ninegua for this PR! I have the impression we can delete more code 😄
I believe this event type is part of the historical events, which are still used during an event playback (e.g, when upgrading the minter). So the code handling them will need to be kept around. |
Ah yes, I read this too quickly. I thought I remembered that the code replaying events allowed the use of deprecated events for backwards compatibility. Thanks for the clarification! |
XC-237
Since the ckBTC minter switched to using the checker canister, it no longer needs to distribute kyt fees, or reimburse failed kyt. These calls can be removed from the code, but we do still need to keep them for event and state handling during replay.