Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(boundary): extend rate-limit canister system-test #3296

Merged

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Dec 27, 2024

  • Verify that adding a rate-limit canister self blocking rule has no impact on the API boundary nodes, i.e. ic-boundary can still fetch rate-limit rules from the canister
  • Add additional step of canister upgrade via proposal (mimics the mainnet behavior)
  • Fixed assertions of checking canister being unreachable/reachable (after applying/removing rate-limit rules).
    • When canister is being effectively rate-limited, one expects 429 status code in response. However, agent does some retries on 429 responses. To avoid any retries in the agent and get expected 429 faster, we implement a custom HttpServiceNoRetry for the agent middleware.
    • Removed unnecessary update call timeout

@github-actions github-actions bot added the chore label Dec 27, 2024
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-system-test-enhancement branch from 4a18909 to 1ca8f97 Compare December 27, 2024 11:06
@nikolay-komarevskiy nikolay-komarevskiy changed the title chore(boundary): extend the rate-limit canister system-test chore(boundary): extend rate-limit canister system-test Dec 27, 2024
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review December 27, 2024 11:12
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner December 27, 2024 11:12
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-system-test-enhancement branch 2 times, most recently from 7df043c to 39b704d Compare January 6, 2025 11:54
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-system-test-enhancement branch from e3557e6 to 61bb8c1 Compare January 7, 2025 12:59
@nikolay-komarevskiy nikolay-komarevskiy added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 806d143 Jan 9, 2025
25 checks passed
@nikolay-komarevskiy nikolay-komarevskiy deleted the komarevskiy/rate-limit-system-test-enhancement branch January 9, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants