chore(ICRC_Index): FI-1468: Remove old ICRC index canister #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster # Conflicts: # Cargo.toml
basvandijk
approved these changes
Dec 23, 2024
maciejdfinity
approved these changes
Dec 23, 2024
aterga
approved these changes
Dec 23, 2024
ninegua
approved these changes
Dec 26, 2024
mbjorkqvist
deleted the
mathias-FI-1468-remove-old-icrc-index-canister
branch
1 task
dskloetd
added a commit
to dfinity/ic-js
that referenced
this pull request
Jan 6, 2025
# Motivation The old ICRC1 index canister was deleted in dfinity/ic#3286 This caused the automatic candid update job to fail when it tried to download the candid for this canister: https://github.com/dfinity/ic-js/actions/runs/12626049412/job/35178612469 I think it will be good to keep the canister in `ic-js` for backwards compatibility, at least for a while. But since the canister code is deleted, the candid definitely won't be changing anymore so we can stop automatically updating it. # Changes Stop updating the candid for the old ICRC1 index canister in `scripts/import-candid`. # Tests Ran the script before and after and saw that it started working again. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ICRC index canister, which stores the blocks on the heap (as opposed to the
index-ngcanister which stores the blocks in stable memory), is deprecated. To avoid confusion, remove it from the repository.