Skip to content

Commit

Permalink
fix(BOUN-1308): use default shell and downgrade release action (#3145)
Browse files Browse the repository at this point in the history
This change applies @nmattia's suggestion about using a default shell.
He also mentioned he believes that bash is the default but prior to this
I had to set the shell to bash so I'm not confident if that is true.

It also downgrades the release action due to
softprops/action-gh-release#556
  • Loading branch information
rikonor authored Dec 12, 2024
1 parent 02b2518 commit 6a8bece
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 12 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/anonymization-backend-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ env:
NAME: anonymization-backend
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

defaults:
run:
shell: bash

jobs:
build-and-release:
name: Build and release the anonymization backend canister
Expand All @@ -37,7 +41,6 @@ jobs:
- uses: actions/checkout@v4

- name: build
shell: bash
run: |
TARGET='//rs/boundary_node/anonymization/backend:anonymization_backend'
bazel build --config=ci ${TARGET}
Expand All @@ -46,7 +49,6 @@ jobs:
mv ${OUTPUT} anonymization_backend.wasm.gz
- name: artifacts
shell: bash
run: |
ARTIFACTS=(
anonymization_backend.wasm.gz
Expand All @@ -57,7 +59,6 @@ jobs:
echo "EOF" >> $GITHUB_ENV
- name: checksums
shell: bash
run: |
CHECKSUMS=$(mktemp)
Expand All @@ -68,15 +69,13 @@ jobs:
echo "CHECKSUMS=${CHECKSUMS}" >> "${GITHUB_ENV}"
- name: tag
shell: bash
run: |
COMMIT_SHORT=$(git rev-parse --short HEAD)
RELEASE_TAG="${{ env.NAME }}-${COMMIT_SHORT}"
echo "RELEASE_TAG=${RELEASE_TAG}" >> "${GITHUB_ENV}"
- name: release notes
shell: bash
run: |
NOTES=$(mktemp)
Expand All @@ -103,7 +102,7 @@ jobs:
echo "NOTES=${NOTES}" >> "${GITHUB_ENV}"
- name: release
uses: softprops/action-gh-release@7b4da11513bf3f43f9999e90eabced41ab8bb048
uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8
with:
tag_name: ${{ env.RELEASE_TAG }}
name: ${{ inputs.title }}
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/rate-limits-backend-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ env:
NAME: rate-limits
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

defaults:
run:
shell: bash

jobs:
build-and-release:
name: Build and release the rate-limits backend canister
Expand All @@ -37,7 +41,6 @@ jobs:
- uses: actions/checkout@v4

- name: build
shell: bash
run: |
TARGET='//rs/boundary_node/rate_limits:rate_limit_canister'
bazel build --config=ci ${TARGET}
Expand All @@ -46,7 +49,6 @@ jobs:
mv ${OUTPUT} rate_limit_canister.wasm.gz
- name: artifacts
shell: bash
run: |
ARTIFACTS=(
rate_limit_canister.wasm.gz
Expand All @@ -57,7 +59,6 @@ jobs:
echo "EOF" >> $GITHUB_ENV
- name: checksums
shell: bash
run: |
CHECKSUMS=$(mktemp)
Expand All @@ -68,15 +69,13 @@ jobs:
echo "CHECKSUMS=${CHECKSUMS}" >> "${GITHUB_ENV}"
- name: tag
shell: bash
run: |
COMMIT_SHORT=$(git rev-parse --short HEAD)
RELEASE_TAG="${{ env.NAME }}-${COMMIT_SHORT}"
echo "RELEASE_TAG=${RELEASE_TAG}" >> "${GITHUB_ENV}"
- name: release notes
shell: bash
run: |
NOTES=$(mktemp)
Expand All @@ -103,7 +102,7 @@ jobs:
echo "NOTES=${NOTES}" >> "${GITHUB_ENV}"
- name: release
uses: softprops/action-gh-release@7b4da11513bf3f43f9999e90eabced41ab8bb048
uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8
with:
tag_name: ${{ env.RELEASE_TAG }}
name: ${{ inputs.title }}
Expand Down

0 comments on commit 6a8bece

Please sign in to comment.