Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optional fields in Block #235

Merged
merged 4 commits into from
Jul 2, 2024
Merged

fix: optional fields in Block #235

merged 4 commits into from
Jul 2, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Jul 1, 2024 •
edited
Loading

Fixes #233 by making the following fields optional:

  1. totalDifficulty
  2. difficulty
  3. baseFeePerGas

@gregorydemay gregorydemay linked an issue Jul 1, 2024 that may be closed by this pull request
Various fields in Block should be optional #233
Closed
@gregorydemay gregorydemay marked this pull request as ready for review July 1, 2024 13:40
@gregorydemay gregorydemay requested a review from rvanasa July 1, 2024 13:40
rvanasa
rvanasa approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for doing this!

@gregorydemay gregorydemay merged commit 3cce151 into main Jul 2, 2024
3 checks passed
@gregorydemay gregorydemay deleted the 233-various-fields-in-block-should-be-optional branch July 2, 2024 07:14
@letmejustputthishere letmejustputthishere mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanasa rvanasa rvanasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various fields in Block should be optional
2 participants
@gregorydemay @rvanasa