fix: do not call done() in stable_restore() #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the call to decoder.done() in stable_restore(). Rationale: * done() almost always returns an error because the input is likely to contain trailing zero bytes. * Calling done() has no effect on the return value. * The error that done() constructs contains the dump of the whole state, which causes the decoder to allocate huge amounts of memory. All of these allocations are unnecessary because stable_restore() throws away the error right away. Fixes #212.
lwshang
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the call to decoder.done() in stable_restore().
Rationale:
done() almost always returns an error because the input is likely
to contain trailing zero bytes.
Calling done() has no effect on the return value.
The error that done() constructs contains the dump of the whole state,
which causes the decoder to allocate huge amounts of memory.
All of these allocations are unnecessary because stable_restore()
throws away the error right away.
Fixes #212.